[coreboot-gerrit] Change in coreboot[master]: src/soc/amd/common/fsp: check FSP binary version.

[Felix Held (Code Review)]

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Name of user not set #1003801, Andrey Petrov, Patrick Rudolph, Julian Schroeder.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58869 )

Change subject: src/soc/amd/common/fsp: check FSP binary version.
......................................................................

Patch Set 1:

(4 comments)

File src/drivers/intel/fsp2_0/include/fsp/info_header.h:

https://review.coreboot.org/c/coreboot/+/58869/comment/72b762b1_70f5829a 
PS1, Line 13: //jsd
?

https://review.coreboot.org/c/coreboot/+/58869/comment/8e7a7d8b_54deb8fd 
PS1, Line 34: #define  FSP_INFO_HEADER_OFF    0x94
this is a redefinition of FSP_HDR_OFFSET

https://review.coreboot.org/c/coreboot/+/58869/comment/15ba850e_833381b1 
PS1, Line 35: fsp_info_header 
this looks like a redefinition of fsp_header right above

File src/drivers/intel/fsp2_0/util.c:

https://review.coreboot.org/c/coreboot/+/58869/comment/43f6067d_35f23825 
PS1, Line 80: 	struct fsp_info_header *info = (struct fsp_info_header *) (fsp_file + FSP_INFO_HEADER_OFF);
not sure why this is needed. last time i checked, soc_validate_fspm_header did what i was expecting