Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32992 )
Change subject: soc/intel/cannonlake: Add ability to disable Heci1 ......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/#/c/32992/10/src/soc/intel/cannonlake/fsp_params... File src/soc/intel/cannonlake/fsp_params.c:
https://review.coreboot.org/#/c/32992/10/src/soc/intel/cannonlake/fsp_params... PS10, Line 344: Disabled Just wanted to point out how this option is "negative" compared to everything around it. Would it make sense to invert it so that it becomes "Heci1Enabled"?