Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31190 )
Change subject: nb/intel/gm45: Use a common romstage ......................................................................
Patch Set 2: Code-Review+1
(2 comments)
https://review.coreboot.org/#/c/31190/2/src/mainboard/lenovo/t400/romstage.c File src/mainboard/lenovo/t400/romstage.c:
https://review.coreboot.org/#/c/31190/2/src/mainboard/lenovo/t400/romstage.c... PS2, Line 71: if (dock_err) that should be in mb_setup_superio, please add a comment and explain why it should stay here
https://review.coreboot.org/#/c/31190/2/src/northbridge/intel/gm45/gm45.h File src/northbridge/intel/gm45/gm45.h:
https://review.coreboot.org/#/c/31190/2/src/northbridge/intel/gm45/gm45.h@44... PS2, Line 442: void get_mb_spd_addrmap(u8 *spd_addrmap); spd_addrmap[4]