Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42810 )
Change subject: soc/amd/picasso: Halt if workbuf is absent after psp_verstage
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/42810/3/src/soc/amd/picasso/bootblo...
File src/soc/amd/picasso/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/42810/3/src/soc/amd/picasso/bootblo...
PS3, Line 134: printk(BIOS_ERR,"ERROR: VBOOT workbuf not valid.\n");
space required after that ',' (ctx:VxV)
clang-format please
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42810
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0ec8d2c953bce4c44cde5102d2765e0ab9b5875e
Gerrit-Change-Number: 42810
Gerrit-PatchSet: 3
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 26 Jun 2020 16:20:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-MessageType: comment