Attention is currently required from: Aaron Durbin, Furquan Shaikh, Julius Werner.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37262?usp=email )
Change subject: util: cbfstool: Add '%<alignment>' in flashmap descriptor
......................................................................
Patch Set 13:
(3 comments)
File util/cbfstool/fmd.h:
https://review.coreboot.org/c/coreboot/+/37262/comment/5eb529e1_fa0e423b :
PS12, Line 41: unsigned alignment;
Prefer 'unsigned int' to bare use of 'unsigned'
Done.
File util/cbfstool/fmd_scanner.c_shipped:
https://review.coreboot.org/c/coreboot/+/37262/comment/23354718_2fa8fc17 :
PS12, Line 164:
trailing whitespace
that's from bison but yes we can remote it.
https://review.coreboot.org/c/coreboot/+/37262/comment/35d35fe9_a832ecbf :
PS12, Line 1671:
trailing whitespace
that's from bison but yes we can remote it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37262?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I26b394590c28667a4afcd521c7caa2009b5b98a9
Gerrit-Change-Number: 37262
Gerrit-PatchSet: 13
Gerrit-Owner: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Attention: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Aaron Durbin
adurbin@chromium.org
Gerrit-Comment-Date: Wed, 14 Jun 2023 03:56:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment