Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34375 )
Change subject: nb/amd/amdht: Use standard coreboot assertions
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34375/1/src/northbridge/amd/amdht/c...
File src/northbridge/amd/amdht/comlib.c:
https://review.coreboot.org/c/coreboot/+/34375/1/src/northbridge/amd/amdht/c...
PS1, Line 251:
I don't think I want to ask about this.
But since you did: it's a calling convention and symbol mangling hint: pascal has case insensitive symbols and might differ in some places when it comes to argument passing.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34375
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6db7565171a345f9afbc9fb37cff8fda58f942df
Gerrit-Change-Number: 34375
Gerrit-PatchSet: 2
Gerrit-Owner: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Timothy Pearson
tpearson@raptorengineering.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 30 Jul 2019 21:10:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment