ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32725 )
Change subject: Replace ENV_RAMSTAGE with ENV_PAYLOAD_LOADER ......................................................................
Patch Set 2: -Code-Review
(1 comment)
Furquan, thanks for that review, it was great.
https://review.coreboot.org/#/c/32725/2/src/arch/x86/include/arch/acpi.h File src/arch/x86/include/arch/acpi.h:
https://review.coreboot.org/#/c/32725/2/src/arch/x86/include/arch/acpi.h@841 PS2, Line 841: #if ENV_PAYLOAD_LOADER && !defined(__SIMPLE_DEVICE__)
I don't think there is a need to guard the declarations here.
I agree. I've gotten confused as to coreboot practice around protos. There should be no need to guard protos but the guards are lots of places. One advantage of such guards is that you will get an error at compile time -- the protos are not defined.Perhaps it is considered less confusing if you get the error at compile time and not link time?