Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36612 )
Change subject: arch/x86: Link NO_XIP_EARLY_STAGES like other stages ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36612/1/src/arch/x86/assembly_entry... File src/arch/x86/assembly_entry.S:
https://review.coreboot.org/c/coreboot/+/36612/1/src/arch/x86/assembly_entry... PS1, Line 36: #if !ENV_STAGE_HAS_DATA_SECTION
Why does no data section imply a bss section?
.bss section is not shared across stages no matter what. There isn't a conditional applied.
Right. It should state that .bss only needs clearing if the stage is run XIP.
https://review.coreboot.org/c/coreboot/+/36612/1/src/include/rules.h File src/include/rules.h:
https://review.coreboot.org/c/coreboot/+/36612/1/src/include/rules.h@277 PS1, Line 277: CONFIG(NO_XIP_EARLY_STAGES))
This doesn't make sense to me.
Should it be guarded differently with something like a !ENV_XIP parameter?