Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45336 )
Change subject: soc/intel/common/basecode: Add Intel common reset code
......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45336/8/src/soc/intel/common/baseco...
File src/soc/intel/common/basecode/reset/reset.c:
https://review.coreboot.org/c/coreboot/+/45336/8/src/soc/intel/common/baseco...
PS8, Line 11: do_global_reset
I'd rather keep the name as-is, for consistency with `do_full_reset` and `do_system_reset` (cf9_rese […]
well, IMHO that should be reworded, too :S see what I wrote here https://review.coreboot.org/c/coreboot/+/45336/7/src/soc/intel/common/block/...
TL;DR wording wise there is no difference between do_<whatever> and <whatever>; it's simply confusing
https://review.coreboot.org/c/coreboot/+/45336/8/src/soc/intel/common/baseco...
PS8, Line 31: global_reset
Hmmm, shouldn't this be `do_global_reset`?
see https://review.coreboot.org/c/coreboot/+/45336/7/src/soc/intel/common/block/...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45336
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icafe931ba9920501cf5448290ddd9f897760bb75
Gerrit-Change-Number: 45336
Gerrit-PatchSet: 8
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Subrata Banik
subi.banik@gmail.com
Gerrit-Comment-Date: Fri, 18 Sep 2020 18:35:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment