Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31590 )
Change subject: google/kukui: Add panel config data for display ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/#/c/31590/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31590/1//COMMIT_MSG@8 PS1, Line 8: Where did you get the panel data from? Maybe add the panel name to the commit message.
Additionally, is it correct that a 240 ms delay is added (or is it microseconds)s
https://review.coreboot.org/#/c/31590/1/src/mainboard/google/kukui/mainboard... File src/mainboard/google/kukui/mainboard.c:
https://review.coreboot.org/#/c/31590/1/src/mainboard/google/kukui/mainboard... PS1, Line 48: Setup Set up
https://review.coreboot.org/#/c/31590/1/src/mainboard/google/kukui/mainboard... PS1, Line 69: 768x1024 Is it not landscape mode?
https://review.coreboot.org/#/c/31590/1/src/mainboard/google/kukui/mainboard... PS1, Line 105: dsi init fail Error messages should be user understandable, and well written. At least
DSI inti failed, display might not work, continuing anyway.