Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31898 )
Change subject: tpm: Add API to query TPM presence
......................................................................
Patch Set 2:
Nitheesh, since this fell our of your patch queue, I took the liberty to repurpose it slightly:
I split out the board side handling and also moved it away from using a memory layout region of its own.
The reason was that we need the is_tpm_detected() function in the new follow up commit that decides what to do with the recovery switch.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31898
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifa7b17085364bb631f43a133839773033721062d
Gerrit-Change-Number: 31898
Gerrit-PatchSet: 2
Gerrit-Owner: nsekar@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: nsekar@codeaurora.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 10 Apr 2019 18:51:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment