Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46034 )
Change subject: drivers/wifi/generic: Add support for generating SMBIOS data
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46034/1/src/drivers/wifi/generic/ge...
File src/drivers/wifi/generic/generic.c:
https://review.coreboot.org/c/coreboot/+/46034/1/src/drivers/wifi/generic/ge...
PS1, Line 279: return 0;
What does returning 0 mean here? no-op or error? elog_add_event_wake returns a positive length.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46034
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If3c056718bdc57f6976ce8e3f8acc7665ec3ccd7
Gerrit-Change-Number: 46034
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 05 Oct 2020 14:58:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment