Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39006 )
Change subject: drivers: Get rid of set_vbe_mode_info_valid ......................................................................
Patch Set 7:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39006/7/src/include/framebuffer_inf... File src/include/framebuffer_info.h:
https://review.coreboot.org/c/coreboot/+/39006/7/src/include/framebuffer_inf... PS7, Line 49: struct edid; Should include <edid.h> instead?
https://review.coreboot.org/c/coreboot/+/39006/7/src/lib/edid_fill_fb.c File src/lib/edid_fill_fb.c:
PS7: Should this file still be called edid_fill_lb.c? Sounds more like a framebuffer_info.c to me by now...
https://review.coreboot.org/c/coreboot/+/39006/7/src/lib/edid_fill_fb.c@162 PS7, Line 162: fb_new_framebuffer_info_from_edid Shouldn't this be called fb_set_framebuffer_info_from_edid(), since it's the equivalent of fb_set_framebuffer_info() (not of fb_new_framebuffer_info())?