David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37233 )
Change subject: mb/ocp/monolake: Create SMBIOS type 16 for Monolake platform ......................................................................
Patch Set 4: Code-Review+2
(3 comments)
Marked old comments as resolved. Thanks!
https://review.coreboot.org/c/coreboot/+/37233/2/src/mainboard/ocp/monolake/... File src/mainboard/ocp/monolake/mainboard.c:
https://review.coreboot.org/c/coreboot/+/37233/2/src/mainboard/ocp/monolake/... PS2, Line 34: (32UL << 20)
#define MAX_DIMM_SIZE_GB (32 * MiB) […]
Done
https://review.coreboot.org/c/coreboot/+/37233/2/src/mainboard/ocp/monolake/... PS2, Line 81: CONFIG_DIMM_MAX/MAX_IMC;
space around / operator […]
Done
https://review.coreboot.org/c/coreboot/+/37233/2/src/mainboard/ocp/monolake/... PS2, Line 119: #endif
if (CONFIG(GENERATE_SMBIOS_TABLES)) […]
Done