13 Mar
2023
13 Mar
'23
7:43 p.m.
Attention is currently required from: Martin L Roth, Matt DeVillier, Fred Reitberger, Karthik Ramasubramanian, Felix Held.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73654 )
Change subject: amdfwtool: Remove the initial alignment on newer SoCs ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/73654/comment/b2a422d2_a67b02d9 PS1, Line 12:
Tracing the code, the next alignment will be TABLE_ALIGNMENT from either `new_combo_dir()` or `new_p […]
Great, thanks.
--
To view, visit https://review.coreboot.org/c/coreboot/+/73654
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I27cbfde2d7d58b62a4c0039c60babc3fb3bd95fa
Gerrit-Change-Number: 73654
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Reviewer: Martin L Roth gaumless@gmail.com
Gerrit-Reviewer: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Martin L Roth gaumless@gmail.com
Gerrit-Attention: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 13 Mar 2023 18:43:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Martin Roth martin.roth@amd.corp-partner.google.com
Comment-In-Reply-To: Fred Reitberger reitbergerfred@gmail.com
Comment-In-Reply-To: Karthik Ramasubramanian kramasub@google.com
Gerrit-MessageType: comment