[coreboot-gerrit] Change in ...coreboot[master]: mediatek: Refactor I2C code among similar SOCs

[wang qii (Code Review)]

wang qii has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30975 )

Change subject: mediatek: Refactor I2C code among similar SOCs
......................................................................

Patch Set 11:

(3 comments)

https://review.coreboot.org/#/c/30975/11/src/soc/mediatek/common/i2c.c 
File src/soc/mediatek/common/i2c.c:

https://review.coreboot.org/#/c/30975/11/src/soc/mediatek/common/i2c.c@41 
PS11, Line 41: (
> any reason to wrap these arguments with ()?

Just feel safer, if you don't feel right, I will get rid of it. Thanks.

https://review.coreboot.org/#/c/30975/11/src/soc/mediatek/common/i2c.c@58 
PS11, Line 58: read
> Would it be better if we rename this parameter to something like "mode"?

Ack

https://review.coreboot.org/#/c/30975/11/src/soc/mediatek/common/i2c.c@241 
PS11, Line 241: read
> same here

Ack