Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29749 )
Change subject: mb/google/dragonegg: Add initial mainboard code support ......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/#/c/29749/9/src/mainboard/google/dragonegg/romst... File src/mainboard/google/dragonegg/romstage_fsp_params.c:
https://review.coreboot.org/#/c/29749/9/src/mainboard/google/dragonegg/romst... PS9, Line 23: void mainboard_memory_init_params(FSPM_UPD *mupd) Can this file be removed, since it contains 1 empty function only?
https://review.coreboot.org/#/c/29749/9/src/mainboard/google/dragonegg/spd/e... File src/mainboard/google/dragonegg/spd/empty.spd.hex:
https://review.coreboot.org/#/c/29749/9/src/mainboard/google/dragonegg/spd/e... PS9, Line 1: 00 Why this empty spd file? Remove it if not used