Attention is currently required from: Hung-Te Lin, Paul Menzel. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52668 )
Change subject: soc/mediatek/mt8195: add pmif/spmi/pmic driver ......................................................................
Patch Set 4:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52668/comment/a839acb5_392460d1 PS3, Line 2: henryc.chen
If you used *Henry Chen*, that’d be great: […]
Done
https://review.coreboot.org/c/coreboot/+/52668/comment/d978e96c_642edfa3 PS3, Line 10: and spi, so we add pmif driver to control pmics.
This change seems to include firmware (encoded in header files). […]
Ack
https://review.coreboot.org/c/coreboot/+/52668/comment/89049ba2_7bca2834 PS3, Line 11:
- Please document the datasheet name and revision. […]
Reference datasheet: MT6315 datasheet v1.4.2.pdf, RH-D-2019-0616. Reference datasheet: MT6359_PMIC_Data_Sheet_V1.5.docx, RH-D-2018-0205.
https://review.coreboot.org/c/coreboot/+/52668/comment/93f9f545_52ccaaa5 PS3, Line 12: henryc.chen
Dito.
Done
Patchset:
PS3:
We generally prefer to have mainboard and SoC level code in separate commits. […]
mb patch: https://review.coreboot.org/c/coreboot/+/52849/1
File src/soc/mediatek/mt8195/pmif_clk.c:
https://review.coreboot.org/c/coreboot/+/52668/comment/bedc335b_b8e26491 PS3, Line 108: if (diff_by_min < diff_by_max) { : cal_result = min; : current_val = pmif_get_ulposc_freq_mhz(min); : } else { : cal_result = max; : current_val = pmif_get_ulposc_freq_mhz(max); : }
Maybe: […]
Done
https://review.coreboot.org/c/coreboot/+/52668/comment/17db89d9_35dce1a2 PS3, Line 119: printk(BIOS_ERR, "[%s] calibration fail: %dM\n", __func__, current_val);
Please also print out `CAL_TOL_RATE` and `target_val`.
Done