Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45063 )
Change subject: mb/../Kconfig: Correct the maximum number of cpu cores for APL platform
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45063/2/src/mainboard/google/reef/K...
File src/mainboard/google/reef/Kconfig:
https://review.coreboot.org/c/coreboot/+/45063/2/src/mainboard/google/reef/K...
PS2, Line 84: config MAX_CPUS
: int
: default 4
I cannot find the default setting in the APL SOC directory. […]
Uh, I mistook `apollolake_rvp` for `soc/intel/apollolake`. Sorry.
Still, it would be good to set a default for MAX_CPUS in there, so that only boards with MAX_CPUS != 4 need to explicitly override the value.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45063
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I555ab72520ab9c174b1656c463a5112eb05a236d
Gerrit-Change-Number: 45063
Gerrit-PatchSet: 3
Gerrit-Owner: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Aaron Durbin
adurbin@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 07 Sep 2020 09:55:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Mario Scheithauer
mario.scheithauer@siemens.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment