[coreboot-gerrit] Change in coreboot[master]: qemu-q35: die if started on wrong machine

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31425 )

Change subject: qemu-q35: die if started on wrong machine
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/31425/3/src/mainboard/emulation/qem... 
File src/mainboard/emulation/qemu-q35/bootblock.c:

https://review.coreboot.org/c/coreboot/+/31425/3/src/mainboard/emulation/qem... 
PS3, Line 46: 	    (pci_read_config32(PCI_DEV(0, 0, 0), D0F0_PCIEXBAR_LO) !=
> Maybe pci_io_read() instead. Without MCFG that pci_read() is invalid access.

The reason this works is it doesn't use pci_io_read. It will try to access the PCI device using MCFG, but of course it doesn't work and thus the check fails.