Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48517 )
Change subject: soc/amd/cezanne: add caching setup in bootblock
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48517/2/src/soc/amd/cezanne/bootblo...
File src/soc/amd/cezanne/bootblock.c:
https://review.coreboot.org/c/coreboot/+/48517/2/src/soc/amd/cezanne/bootblo...
PS2, Line 59: ALIGN_DOWN(top_mem.lo, 8*MiB)
only works if this is a power of 2
https://review.coreboot.org/c/coreboot/+/48517/2/src/soc/amd/cezanne/bootblo...
PS2, Line 60: CONFIG_ROM_SIZE
reuse CAR_CACHE_ROM_SIZE to make sure it's a power of 2?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48517
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5fc158518cf9534ab9727f3305abeb4b34049e76
Gerrit-Change-Number: 48517
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 10 Dec 2020 00:00:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment