Attention is currently required from: Damien Zammit, Angel Pons.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50353 )
Change subject: nb/intel/x4x/raminit: Fix Clock Enable on DDR3
......................................................................
Patch Set 3:
(1 comment)
File src/northbridge/intel/x4x/raminit_ddr23.c:
https://review.coreboot.org/c/coreboot/+/50353/comment/71395a31_395570ef
PS3, Line 779: * clock for all ranks.
nb/intel/i945 has the `OVERRIDE_CLOCK_DISABLE` Kconfig option, maybe add it to x4x as well? We know other x4x boards work well with DDR3 (various G41 boards, and the Acer G43T-AM3).
Sounds good.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50353
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie1eb77ed2d2b563fb3b92ca33b900f7d1dbc85fe
Gerrit-Change-Number: 50353
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Damien Zammit
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Sat, 06 Feb 2021 15:13:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment