Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35542 )
Change subject: soc/intel/skylake: devicetree: introduce PchHdaVcType fsp parameter
......................................................................
Patch Set 15:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35542/15/src/soc/intel/skylake/chip...
File src/soc/intel/skylake/chip.h:
https://review.coreboot.org/c/coreboot/+/35542/15/src/soc/intel/skylake/chip...
PS15, Line 213: Vc0,
What is the default in various FSP binaries? SKL and KBL? And is Vc0 ok in practice?
Vc0 is ok in pratice at least for boards that have HDA disabled and do not crash with Vc0 due to NULL pointer deref
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35542
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibafc3b6bd2495658f2bd634218042ec413a89f5e
Gerrit-Change-Number: 35542
Gerrit-PatchSet: 15
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 02 Oct 2019 15:33:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment