Attention is currently required from: Nico Huber, Krystian Hebel, Kyösti Mälkki, Felix Held.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52926 )
Change subject: nb/amd/pi/00730F01/northbridge.c: Use generic allocation functions
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
didn't spot anything that looked obviously wrong and since it has 100% test coverage, i'm confident […]
It basically changes nothing, except the order the code is executed. Without the patch, the memory ranges were discovered during setting resources phase and marked as usable. Now it is done during read resources phase which is correct right? SAme goes for the similar patch for family14.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52926
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8dd5e40bce513c5ba7f1d42a06e7ab0846666942
Gerrit-Change-Number: 52926
Gerrit-PatchSet: 3
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 07 May 2021 18:22:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment
