Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46110 )
Change subject: mrc_cache: Add data_size parameter to mrc_cache_load_current ......................................................................
Patch Set 2:
(3 comments)
s
https://review.coreboot.org/c/coreboot/+/46110/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46110/1//COMMIT_MSG@10 PS1, Line 10: This is needed for ARM devices like trogdor, which : need to know the size of the training data when populating the QcLib : interface table.
You know, thinking about this some more, I think it is more appropriate to specify the full size of […]
Changed so return value is data size.
https://review.coreboot.org/c/coreboot/+/46110/1/src/drivers/mrc_cache/mrc_c... File src/drivers/mrc_cache/mrc_cache.c:
https://review.coreboot.org/c/coreboot/+/46110/1/src/drivers/mrc_cache/mrc_c... PS1, Line 273: *data_size =
Let's make this optional, e.g. […]
Changed so return value is data size.
https://review.coreboot.org/c/coreboot/+/46110/1/src/include/mrc_cache.h File src/include/mrc_cache.h:
https://review.coreboot.org/c/coreboot/+/46110/1/src/include/mrc_cache.h@33 PS1, Line 33: int
I don't see a problem with changing that. […]
Done