Tim Crawford has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/87068?usp=email )
Change subject: ec/system76/ec: Add config for 2nd fan without GPU ......................................................................
ec/system76/ec: Add config for 2nd fan without GPU
The darp10 has a second fan but no dGPU. The NFAN Method must exist, so use the default hwmon names of "fan1" and "fan2" for labels.
Change-Id: I553deefea374b9dd916be6611850fca61afd490d Signed-off-by: Tim Crawford tcrawford@system76.com --- M src/ec/system76/ec/Kconfig M src/ec/system76/ec/acpi/s76.asl 2 files changed, 15 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/87068/1
diff --git a/src/ec/system76/ec/Kconfig b/src/ec/system76/ec/Kconfig index 4b71912..f0702a7 100644 --- a/src/ec/system76/ec/Kconfig +++ b/src/ec/system76/ec/Kconfig @@ -6,16 +6,22 @@ System76 EC
config EC_SYSTEM76_EC_BAT_THRESHOLDS - depends on EC_SYSTEM76_EC bool default y + depends on EC_SYSTEM76_EC + +config EC_SYSTEM76_EC_FAN2 + bool + default n + depends on EC_SYSTEM76_EC
config EC_SYSTEM76_EC_DGPU - depends on EC_SYSTEM76_EC bool default n + select EC_SYSTEM76_EC_FAN2 + depends on EC_SYSTEM76_EC
config EC_SYSTEM76_EC_OLED - depends on EC_SYSTEM76_EC bool default n + depends on EC_SYSTEM76_EC diff --git a/src/ec/system76/ec/acpi/s76.asl b/src/ec/system76/ec/acpi/s76.asl index 06000a4..f3e2dec 100644 --- a/src/ec/system76/ec/acpi/s76.asl +++ b/src/ec/system76/ec/acpi/s76.asl @@ -126,9 +126,14 @@ // Fan names Method (NFAN, 0, Serialized) { Return (Package() { - "CPU fan", #if CONFIG(EC_SYSTEM76_EC_DGPU) + "CPU fan", "GPU fan", +#elif CONFIG(EC_SYSTEM76_EC_FAN2) + "fan1", + "fan2", +#else + "CPU fan", #endif }) }