Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32682 )
Change subject: mb/samsung/lumpy: Fix MRC raminit
......................................................................
Patch Set 2:
What was broken? Is this change based on hardware testing or review of source code?
You need to remember that somewhere along the way, MRC.bin _and_ version of pei_data changed, that was related to 0xf0 removal from SPD map.
It's not that long ago (maybe 4 months) when I last did fresh build of samsung/lumpy using non-native raminit (I was looking into the ill-located MRC heap) and I am pretty sure I did not have any trouble related to amount of detected memory (2 GiB on-board + 4 GiB SO-DIMM).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32682
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If1910e82a4bd178c2a6c2991c91e09782122888e
Gerrit-Change-Number: 32682
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 08 May 2019 18:27:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment