Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37667 )
Change subject: libpayload: Read from cbmem console
......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/37667/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/37667/2//COMMIT_MSG@7
PS2, Line 7: libpayload: Read from cbmem console
Implement reading from CBMEM console
https://review.coreboot.org/c/coreboot/+/37667/2//COMMIT_MSG@11
PS2, Line 11: that
Could be removed.
https://review.coreboot.org/c/coreboot/+/37667/2//COMMIT_MSG@12
PS2, Line 12: returned string is printable.
I was wondering, why there might be unprintable characters, and found your comment in the implementation.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37667
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie324055f5fd8276f1d833fc9d04f60a792dbb9f6
Gerrit-Change-Number: 37667
Gerrit-PatchSet: 2
Gerrit-Owner: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Shelley Chen
shchen@google.com
Gerrit-CC: Ting Shen
phoenixshen@chromium.org
Gerrit-Comment-Date: Thu, 12 Dec 2019 15:04:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment