Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36992 )
Change subject: mb/gigabyte/ga-b75m-d3h: Add ga-b75-d3v as a variant
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36992/5/src/mainboard/gigabyte/ga-b...
File src/mainboard/gigabyte/ga-b75m-d3h/variants/ga-b75-d3v/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/36992/5/src/mainboard/gigabyte/ga-b...
PS5, Line 20: io 0x62 = 0x230
How about explicitly setting both io resources here?
The latter resource will override the former with the same type. You can reproduce this behavior with the sconfig prior to CB:37109.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36992
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1a969880e4da02abf8ba73aac60ee1296fe0abf2
Gerrit-Change-Number: 36992
Gerrit-PatchSet: 5
Gerrit-Owner: Bill XIE
persmule@hardenedlinux.org
Gerrit-Reviewer: Bill XIE
persmule@hardenedlinux.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 25 Nov 2019 04:49:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Bill XIE
persmule@hardenedlinux.org
Gerrit-MessageType: comment