Attention is currently required from: Kyösti Mälkki.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48787 )
Change subject: [WIP] soc/intel/broadwell: Skip PRE_GRAPHICS_DELAY
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/broadwell/gma.c:
https://review.coreboot.org/c/coreboot/+/48787/comment/2dfdeaf6_881acd43
PS2, Line 516: if (!acpi_is_wakeup_s3()) {
: if (!CONFIG(CHROMEOS) || display_init_required())
this should probably be something like:
if (!acpi_is_wakeup_s3() && (CONFIG(VGA_ROM_RUN) ||
(CONFIG(CHROMEOS) && display_init_required()))) {
mdelay(CONFIG_PRE_GRAPHICS_DELAY);
}
as the delay isn't needed on S3 resume or with libgfxinit, only VBIOS
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48787
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4503158576f35057373f003586bbf76af4d59b3d
Gerrit-Change-Number: 48787
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Thu, 14 Jan 2021 18:50:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment