wang qii has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30975 )
Change subject: mediatek: Refactor I2C code among similar SOCs ......................................................................
Patch Set 12:
(2 comments)
https://review.coreboot.org/#/c/30975/12/src/soc/mediatek/common/i2c.c File src/soc/mediatek/common/i2c.c:
https://review.coreboot.org/#/c/30975/12/src/soc/mediatek/common/i2c.c@156 PS12, Line 156: ASYNC_MODE | DMAACK_EN |
These two flags are new here. […]
If AP_DMA and I2C use different source clocks, need enbale ASYNC_MODE and DMAACK_EN so that hardware will synchronize signals between AP_DMA and I2C. New ICs use different source clocks between AP_DMA and I2C.
https://review.coreboot.org/#/c/30975/12/src/soc/mediatek/mt8173/i2c.c File src/soc/mediatek/mt8173/i2c.c:
https://review.coreboot.org/#/c/30975/12/src/soc/mediatek/mt8173/i2c.c@83 PS12, Line 83: static inline void i2c_dma_reset(struct mt_i2c_dma_regs *dma_regs)
Unused now?
It will be removed to src/soc/mediatek/common/i2c.c