Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik.
Leo Chou has posted comments on this change by Leo Chou. ( https://review.coreboot.org/c/coreboot/+/82702?usp=email )
Change subject: mb/google/nissa/var/pujjoga: Add wifi sar table
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/brya/variants/pujjoga/variant.c:
https://review.coreboot.org/c/coreboot/+/82702/comment/5b9d23c3_4a9af2cd?usp... :
PS3, Line 4: #include <baseboard/variants.h>
do you need this?
Don't need, remove it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82702?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If0f542cb13e93e99960bf65d616b26cee7617a43
Gerrit-Change-Number: 82702
Gerrit-PatchSet: 3
Gerrit-Owner: Leo Chou
leo.chou@lcfc.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Thu, 30 May 2024 08:35:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
ericllai@google.com