Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46808 )
Change subject: mb/google/octopus/variants/bobba: Add G2Touch touchscreen support ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46808/2/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/bobba/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/46808/2/src/mainboard/google/octopu... PS2, Line 216: ACPI_IRQ_EDGE_LOW
Please refer to commit [1] where mentioned that The first release of the HID over I2C specification […]
This is from the latest specification[1]:
"DEVICE is responsible to assert the interrupt line (level trigger interrupt required) when it has data.
DEVICE must keep the interrupt line asserted until the data has been fully read by the HOST. After this point, the DEVICE must de-assert the interrupt line if it has no more data to report to the HOST.
When the DEVICE has new data to report, it must repeat the process above."
Also, if you see "Updates between v0.91 and v1.0", it says: "Level triggered interrupts changed to “required” from “recommended”. "
[1] http://download.microsoft.com/download/7/d/d/7dd44bb7-2a7a-4505-ac1c-7227d3d...