Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38743 )
Change subject: nb/intel/haswell/peg: Add PEG driver stub ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38743/5/src/northbridge/intel/haswe... File src/northbridge/intel/haswell/pcie.c:
https://review.coreboot.org/c/coreboot/+/38743/5/src/northbridge/intel/haswe... PS5, Line 53: if (dev->path.pci.devfn == PCI_DEVFN(0, 0) && : port->bus->secondary == 0 && : (port->path.pci.devfn == PCI_DEVFN(1, 0) || : port->path.pci.devfn == PCI_DEVFN(1, 1) || : port->path.pci.devfn == PCI_DEVFN(1, 2))) : return "DEV0";
That doesn't cover device 01.1 or 01.2.
Yes. As I said, "PEG0 could be". In any case, it's the same thing for these two as well:
if (port->bus->secondary == 0) { switch (port->path.pci.devfn) { case PCI_DEVFN(1, 0): case PCI_DEVFN(1, 1): case PCI_DEVFN(1, 2): switch (dev->path.pci.devfn) { case PCI_DEVFN(0, 0): return "PEGP";
case PCI_DEVFN(0, 1): return "PEGA"; } break; } }