[coreboot-gerrit] Change in coreboot[master]: mb/amd,google/zork: Move init_tables() call

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/50717 )

Change subject: mb/amd,google/zork: Move init_tables() call
......................................................................

mb/amd,google/zork: Move init_tables() call

The semantics of pirq_setup() from previous platforms was to
only setup the global pointers for PIC and APIC tables, not
to create or modify the tables themselves.

Change-Id: Iaa7c31eed21432dc2b3fe6b32803bd2658fd5e2d
Signed-off-by: Kyösti Mälkki 
---
M src/mainboard/amd/majolica/mainboard.c
M src/mainboard/amd/mandolin/mainboard.c
M src/mainboard/google/zork/mainboard.c
3 files changed, 5 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/50717/1

diff --git a/src/mainboard/amd/majolica/mainboard.c b/src/mainboard/amd/majolica/mainboard.c
index cbb1145..a02a9a7 100644
--- a/src/mainboard/amd/majolica/mainboard.c
+++ b/src/mainboard/amd/majolica/mainboard.c
@@ -81,13 +81,13 @@

static void pirq_setup(void)
 {
-	init_tables();
    intr_data_ptr = fch_apic_routing;
    picr_data_ptr = fch_pic_routing;
 }

static void mainboard_init(void *chip_info)
 {
+	init_tables();
 }

static void majolica_enable(struct device *dev)
diff --git a/src/mainboard/amd/mandolin/mainboard.c b/src/mainboard/amd/mandolin/mainboard.c
index 0d208da..a01be3c 100644
--- a/src/mainboard/amd/mandolin/mainboard.c
+++ b/src/mainboard/amd/mandolin/mainboard.c
@@ -75,7 +75,6 @@

static void pirq_setup(void)
 {
-	init_tables();
    intr_data_ptr = fch_apic_routing;
    picr_data_ptr = fch_pic_routing;
 }
@@ -94,6 +93,8 @@
    	printk(BIOS_INFO, "eMMC not available due to LPC requirement\n");
    else
    	mainboard_program_emmc_gpios();
+
+	init_tables();
 }

static void mandolin_enable(struct device *dev)
diff --git a/src/mainboard/google/zork/mainboard.c b/src/mainboard/google/zork/mainboard.c
index 1558245..26da72c 100644
--- a/src/mainboard/google/zork/mainboard.c
+++ b/src/mainboard/google/zork/mainboard.c
@@ -104,7 +104,6 @@
 /* PIRQ Setup */
 static void pirq_setup(void)
 {
-	init_tables();
    intr_data_ptr = fch_apic_routing;
    picr_data_ptr = fch_pic_routing;
 }
@@ -141,6 +140,8 @@

/* Update DUT configuration */
    mainboard_devtree_update();
+
+	init_tables();
 }

void mainboard_get_dxio_ddi_descriptors(const fsp_dxio_descriptor **dxio_descs,