Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33839 )
Change subject: src/mainboard/protectli/vault_kbl: Add FW6 boards support ......................................................................
Patch Set 2:
(5 comments)
You might want to try "make gitconfig", so that it catches lint errors before committing.
I guess this is WIP?
https://review.coreboot.org/#/c/33839/2/src/mainboard/protectli/vault_kbl/Kc... File src/mainboard/protectli/vault_kbl/Kconfig.name:
https://review.coreboot.org/#/c/33839/2/src/mainboard/protectli/vault_kbl/Kc... PS2, Line 4: Extra newline
https://review.coreboot.org/#/c/33839/2/src/mainboard/protectli/vault_kbl/ac... File src/mainboard/protectli/vault_kbl/acpi/ec.asl:
https://review.coreboot.org/#/c/33839/2/src/mainboard/protectli/vault_kbl/ac... PS2, Line 16: Extra newline
https://review.coreboot.org/#/c/33839/2/src/mainboard/protectli/vault_kbl/ac... File src/mainboard/protectli/vault_kbl/acpi_tables.c:
PS2: Copyright on what? If this file is not going to be used, please remove it, or leave it empty.
https://review.coreboot.org/#/c/33839/2/src/mainboard/protectli/vault_kbl/bo... File src/mainboard/protectli/vault_kbl/board_info.txt:
https://review.coreboot.org/#/c/33839/2/src/mainboard/protectli/vault_kbl/bo... PS2, Line 1: Vendor name: Intel : Board name: Kabylake RVP Reference Board I don't think so :D
https://review.coreboot.org/#/c/33839/2/src/mainboard/protectli/vault_kbl/ra... File src/mainboard/protectli/vault_kbl/ramstage.c:
https://review.coreboot.org/#/c/33839/2/src/mainboard/protectli/vault_kbl/ra... PS2, Line 35: Extra newline