Attention is currently required from: Maulik V Vaghela.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51765 )
Change subject: mb/intel/adlrvp: Remove static VBT stitching
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51765/comment/cdaa9aed_c2b2cb3b
PS2, Line 13: This removing these lines to avoid compilation issues in emerge builds
What is the “emerge build”, and what does it do differently? To my knowledge that’s used for Chrome OS, but what does it have to do with upstream coreboot? How are the files added now?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51765
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I69f1cc6c07415515ff85180fdd7cc5de11b4d805
Gerrit-Change-Number: 51765
Gerrit-PatchSet: 2
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Spoorthi K
spoorthi.k@intel.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Comment-Date: Fri, 26 Mar 2021 07:54:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment