Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45286 )
Change subject: amdfwtool: Clean up the Makefile of amdfwtool
......................................................................
Patch Set 11:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45286/11/util/amdfwtool/Makefile
File util/amdfwtool/Makefile:
https://review.coreboot.org/c/coreboot/+/45286/11/util/amdfwtool/Makefile@17
PS11, Line 17: amdfwtool_exe
change to 'all:' or remove?
https://review.coreboot.org/c/coreboot/+/45286/1/util/amdfwtool/Makefile.inc
File util/amdfwtool/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/45286/1/util/amdfwtool/Makefile.inc...
PS1, Line 11: -Wno-sign-compare
Why? I think we'd want to know this.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45286
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3688d93de4459f5f838955892086b4b9bf30a9b8
Gerrit-Change-Number: 45286
Gerrit-PatchSet: 11
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Dave Frodin
dave.frodin@se-eng.com
Gerrit-CC: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-CC: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-CC: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 29 Sep 2020 17:49:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
