Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48842 )
Change subject: soc/amd/common: Detect SOC before access ESPI register
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48842/1/src/soc/amd/common/block/lp...
File src/soc/amd/common/block/lpc/espi_util.c:
https://review.coreboot.org/c/coreboot/+/48842/1/src/soc/amd/common/block/lp...
PS1, Line 828: SOC_AMD_CEZANNE
only had a very brief look, but adding a Kconfig option in soc/amd/common/block/lpc/Kconfig like ESP […]
might also be worth a thought to move the check to espi_setup and only call espi_setup_subtractive_decode if the platform supports subtractive decodes
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48842
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icb8e8a1a59393849395125108bfaa884839ce10f
Gerrit-Change-Number: 48842
Gerrit-PatchSet: 1
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Tue, 29 Dec 2020 18:19:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment