Attention is currently required from: Martin Roth, Julius Werner, mturney mturney. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49768 )
Change subject: sc7280: cpucp loading changes ......................................................................
Patch Set 21:
(42 comments)
File src/soc/qualcomm/sc7280/cpucp_load_reset.c:
https://review.coreboot.org/c/coreboot/+/49768/comment/f6894a4e_b974368c PS21, Line 15: uint32_t val = read32(EPSSTOP_SECURE_ACCESS_OVERRIDE); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/6ea7ea9c_fa2e1eb7 PS21, Line 15: uint32_t val = read32(EPSSTOP_SECURE_ACCESS_OVERRIDE); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49768/comment/7ce7a30a_17d09ab3 PS21, Line 16: val |= 0x1; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/0b5d1808_5920c4fa PS21, Line 16: val |= 0x1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49768/comment/7a0644cc_ddda340e PS21, Line 18: /* allow NS access to EPSS memory*/ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/c6b65f3c_f3fc2f42 PS21, Line 19: write32(EPSSTOP_SECURE_ACCESS_OVERRIDE, val); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/15304e68_8efec351 PS21, Line 19: write32(EPSSTOP_SECURE_ACCESS_OVERRIDE, val); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49768/comment/5fc7ac4d_d05a61a3 PS21, Line 21: val = read32(EPSSFAST_EPSS_MUC_CLK_CTRL); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/b1e5ff17_ccfeec88 PS21, Line 21: val = read32(EPSSFAST_EPSS_MUC_CLK_CTRL); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49768/comment/f73e1b76_b9780ca6 PS21, Line 22: val |= 0x1; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/8395f0ad_f8c685b3 PS21, Line 22: val |= 0x1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49768/comment/4997753a_a772fd98 PS21, Line 24: /* Enable subsystem clock. Required for CPUCP PDMEM access*/ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/8fc10920_1e25e28b PS21, Line 25: write32(EPSSFAST_EPSS_MUC_CLK_CTRL, val); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/69a593c5_37c32987 PS21, Line 25: write32(EPSSFAST_EPSS_MUC_CLK_CTRL, val); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49768/comment/903911f9_6a38e415 PS21, Line 27: while((read32(EPSSFAST_EPSS_MUC_CLK_CTRL) & 0x1) != 0x1); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/4cb5a77f_113f3a8c PS21, Line 27: while((read32(EPSSFAST_EPSS_MUC_CLK_CTRL) & 0x1) != 0x1); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49768/comment/2be27286_185727b9 PS21, Line 27: while((read32(EPSSFAST_EPSS_MUC_CLK_CTRL) & 0x1) != 0x1); space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/49768/comment/118aee43_8d91fc9a PS21, Line 27: while((read32(EPSSFAST_EPSS_MUC_CLK_CTRL) & 0x1) != 0x1); trailing statements should be on next line
https://review.coreboot.org/c/coreboot/+/49768/comment/ee9ec7e1_85cdf916 PS21, Line 32: bool cpucp_fw_entry; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/42713792_05f08393 PS21, Line 32: bool cpucp_fw_entry; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49768/comment/ef6ec57b_085764a0 PS21, Line 33: printk(BIOS_DEBUG, "\nSOC:CPUCP image loading.\n"); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/edfc6193_cde2334a PS21, Line 33: printk(BIOS_DEBUG, "\nSOC:CPUCP image loading.\n"); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49768/comment/ae7cf4a7_9cf2d264 PS21, Line 35: struct prog cpucp_fw_prog = code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/56d3b7f9_cacc1ca5 PS21, Line 35: struct prog cpucp_fw_prog = please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49768/comment/9118cfb1_307e331e PS21, Line 36: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/cpucp"); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/ddacbb6d_070cb46b PS21, Line 36: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/cpucp"); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49768/comment/10582e4f_db14a84e PS21, Line 38: cpucp_prepare(); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/1c1709e4_b51f4a52 PS21, Line 38: cpucp_prepare(); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49768/comment/e1b6c980_4e0003ee PS21, Line 40: if (prog_locate(&cpucp_fw_prog)) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/ed26e733_ce7a281c PS21, Line 40: if (prog_locate(&cpucp_fw_prog)) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49768/comment/b11e7a9d_0f0672bb PS21, Line 41: die("SOC imagpe: CPUCP_FW not found"); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/0f8ab992_8a2458fc PS21, Line 41: die("SOC imagpe: CPUCP_FW not found"); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49768/comment/67714254_a538f159 PS21, Line 43: cpucp_fw_entry = selfload(&cpucp_fw_prog); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/9a9f32f9_b69065be PS21, Line 43: cpucp_fw_entry = selfload(&cpucp_fw_prog); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49768/comment/951b30ba_44e2590a PS21, Line 44: if (!cpucp_fw_entry) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/a3c37f3a_5d7381c5 PS21, Line 44: if (!cpucp_fw_entry) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49768/comment/27d67647_ff321beb PS21, Line 45: die("SOC image: CPUCP load failed"); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/64844814_08ccadad PS21, Line 45: die("SOC image: CPUCP load failed"); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49768/comment/231a23b4_8667e90c PS21, Line 49: printk(BIOS_DEBUG, "\nSOC:CPUCP image loaded successfully.\n"); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/49eda632_318f694f PS21, Line 49: printk(BIOS_DEBUG, "\nSOC:CPUCP image loaded successfully.\n"); please, no spaces at the start of a line
File src/soc/qualcomm/sc7280/soc.c:
https://review.coreboot.org/c/coreboot/+/49768/comment/5b8b8be3_6336e17a PS21, Line 20: REGION_SIZE(dram_cpucp) / KiB); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/ebe32014_2b98b42d PS21, Line 20: REGION_SIZE(dram_cpucp) / KiB); please, no spaces at the start of a line