Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48514 )
Change subject: soc/amd/picasso: move UART Kconfig options to common folder
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48514/1/src/soc/amd/common/block/ua...
File src/soc/amd/common/block/uart/Kconfig:
https://review.coreboot.org/c/coreboot/+/48514/1/src/soc/amd/common/block/ua...
PS1, Line 42: AMD_SOC_UART_LEGACY
This can use a 'depends on' at some point, as it won't be available on all generations. […]
when stoneyridge will be converted to use this, i should probably add a kconfig option AMD_SOC_UART_HAS_LEGACY_IO and only select that for picasso and newer. I'd like to avoid having not strictly necessary checks for the different soc generations in the common code
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48514
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie4ddf1951b230323c5480c4389376c62dd74b0e1
Gerrit-Change-Number: 48514
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 12 Dec 2020 22:06:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-MessageType: comment