Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46133 )
Change subject: sb/intel/lynxpoint: Enable/disable AER via Kconfig ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/c/coreboot/+/46133/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46133/1//COMMIT_MSG@9 PS1, Line 9: Semi-recent changes to the Linux kernel
It’d be great, if you referenced the Linux commit.
Done
https://review.coreboot.org/c/coreboot/+/46133/1//COMMIT_MSG@20 PS1, Line 20: dmesg log free of AER errors.
Do these errors just spam the logs, or does it cause “real problems”?
Done
https://review.coreboot.org/c/coreboot/+/46133/1/src/southbridge/intel/lynxp... File src/southbridge/intel/lynxpoint/pcie.c:
https://review.coreboot.org/c/coreboot/+/46133/1/src/southbridge/intel/lynxp... PS1, Line 675: ~(1 << 29)
Yes
Done
https://review.coreboot.org/c/coreboot/+/46133/1/src/southbridge/intel/lynxp... PS1, Line 676: (1 << 29) | 0x10001);
Ack
Done