HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/18548 )
Change subject: nb/intel/i945: Program CxODT value for each channel ......................................................................
Patch Set 30:
(7 comments)
https://review.coreboot.org/c/coreboot/+/18548/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/18548/4//COMMIT_MSG@7 PS4, Line 7: nb/intel/i945: Fix sdram_on_die_termination
I think the summary is better served, by describing what you fix as people don’t memorize the functi […]
Ack
https://review.coreboot.org/c/coreboot/+/18548/1/src/northbridge/intel/i945/... File src/northbridge/intel/i945/raminit.c:
https://review.coreboot.org/c/coreboot/+/18548/1/src/northbridge/intel/i945/... PS1, Line 2803: ((!(sysinfo->dimm[0] != SYSINFO_DIMM_NOT_POPULATED && : sysinfo->dimm[1] != SYSINFO_DIMM_NOT_POPULATED)) && : (sysinfo->dimm[0] != SYSINFO_DIMM_NOT_POPULATED || : sysinfo->dimm[1] != SYSINFO_DIMM_NOT_POPULATED)) && : ((!(sysinfo->dimm[2] != SYSINFO_DIMM_NOT_POPULATED && : sysinfo->dimm[3] != SYSINFO_DIMM_NOT_POPULATED)) && : (sysinfo->dimm[2] != SYSINFO_DIMM_NOT_POPULATED || : sysinfo->dimm[3] != SYSINFO_DIMM_NOT_POPULATED)) {
Please make variables for this, because this is not readable. […]
Ack
https://review.coreboot.org/c/coreboot/+/18548/2/src/northbridge/intel/i945/... File src/northbridge/intel/i945/raminit.c:
https://review.coreboot.org/c/coreboot/+/18548/2/src/northbridge/intel/i945/... PS2, Line 2796: s
No 's'
Ack
https://review.coreboot.org/c/coreboot/+/18548/4/src/northbridge/intel/i945/... File src/northbridge/intel/i945/raminit.c:
https://review.coreboot.org/c/coreboot/+/18548/4/src/northbridge/intel/i945/... PS4, Line 2825: if (chan0has1dimm) { : printk(BIOS_DEBUG, "one dimm per channel config..\n");
Please check again […]
Ack
https://review.coreboot.org/c/coreboot/+/18548/10/src/northbridge/intel/i945... File src/northbridge/intel/i945/raminit.c:
https://review.coreboot.org/c/coreboot/+/18548/10/src/northbridge/intel/i945... PS10, Line 2830: 0x1fc8ffff
seems to be 0x1fc80000 for 8086:2770
Ack
https://review.coreboot.org/c/coreboot/+/18548/14/src/northbridge/intel/i945... File src/northbridge/intel/i945/raminit.c:
https://review.coreboot.org/c/coreboot/+/18548/14/src/northbridge/intel/i945... PS14, Line 2458: have
Done
Ack
https://review.coreboot.org/c/coreboot/+/18548/14/src/northbridge/intel/i945... PS14, Line 2466: Channel
Done
Ack