Attention is currently required from: Christian Walter, Filip Lewiński, Michał Kopeć, Michał Żygowski.
Krystian Hebel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82037?usp=email )
Change subject: security/tpm: Add TPM2 NV_ReadPublic command support ......................................................................
Patch Set 4:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82037/comment/3e45ae9e_bf9e8cc9 : PS4, Line 8: Some description would be appreciated.
File src/security/tpm/tss.h:
https://review.coreboot.org/c/coreboot/+/82037/comment/c56161a8_c3e9ae77 : PS4, Line 33: #include <security/tpm/tss/tcg-2.0/tss_structures.h> This file is already unconditionally included few lines above.
https://review.coreboot.org/c/coreboot/+/82037/comment/9ec0cd3a_945f9994 : PS4, Line 35: uint32_t tlcl_define_space(uint32_t space_index, size_t space_size, I can't see the definition of these functions, other than `tlcl_nv_read_public()`, perhaps they are leftovers from another change?
File src/security/tpm/tss/tcg-2.0/tss.c:
https://review.coreboot.org/c/coreboot/+/82037/comment/8d6efaf5_0644d85f : PS4, Line 394: uint32_t tlcl_nv_read_public(uint32_t space_index, All other functions are named `tlcl2_*` here, and both TPM1 and 2 versions are handled by `TLCL_CALL()` macro in inline functions in tss.h, this shouldn't be an exception. If the function doesn't exist in TPM1, appropriate error should be returned instead.