Attention is currently required from: Christian Walter, Filip Lewiński, Michał Kopeć, Michał Żygowski.
4 comments:
Commit Message:
Some description would be appreciated.
File src/security/tpm/tss.h:
Patch Set #4, Line 33: #include <security/tpm/tss/tcg-2.0/tss_structures.h>
This file is already unconditionally included few lines above.
Patch Set #4, Line 35: uint32_t tlcl_define_space(uint32_t space_index, size_t space_size,
I can't see the definition of these functions, other than `tlcl_nv_read_public()`, perhaps they are leftovers from another change?
File src/security/tpm/tss/tcg-2.0/tss.c:
Patch Set #4, Line 394: uint32_t tlcl_nv_read_public(uint32_t space_index,
All other functions are named `tlcl2_*` here, and both TPM1 and 2 versions are handled by `TLCL_CALL()` macro in inline functions in tss.h, this shouldn't be an exception. If the function doesn't exist in TPM1, appropriate error should be returned instead.
To view, visit change 82037. To unsubscribe, or for help writing mail filters, visit settings.