Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39370 )
Change subject: soc/intel/common: Add ACPI support for PMC core OS driver ......................................................................
soc/intel/common: Add ACPI support for PMC core OS driver
PMC core OS driver (intel_pmc_core.c in linux kernel) provides debug hooks to developers and end users to quickly figure out why their platform is not entering a deeper idle state such as S0ix.
This patch adds INT33A1 ACPI device to support PMC core OS driver. Any SoC that supports this feature would include this asl file to enable the support.
BUG=b:146236297 BRANCH=none TEST="Build and flash volteer and verify it boots to kernel"
Change-Id: Ib4edc7b636725177d508b62d15633534e9f44236 Signed-off-by: Venkata Krishna Nimmagadda venkata.krishna.nimmagadda@intel.com Reviewed-on: https://chrome-internal-review.googlesource.com/c/chromeos/third_party/coreb... Reviewed-by: Venkata Krishna Nimmagadda venkata.krishna.nimmagadda@intel.corp-partner.google.com Reviewed-by: Wonkyu Kim wonkyu.kim@intel.corp-partner.google.com Reviewed-by: Caveh Jalali caveh@google.com Reviewed-by: Nick Vaccaro nvaccaro@google.com Tested-by: Venkata Krishna Nimmagadda venkata.krishna.nimmagadda@intel.corp-partner.google.com Commit-Queue: Alex Levin levinale@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/39370 Reviewed-by: Venkata Krishna Nimmagadda Venkata.krishna.nimmagadda@intel.com Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- A src/soc/intel/common/block/acpi/acpi/pmc.asl 1 file changed, 21 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Venkata Krishna Nimmagadda: Looks good to me, but someone else must approve
diff --git a/src/soc/intel/common/block/acpi/acpi/pmc.asl b/src/soc/intel/common/block/acpi/acpi/pmc.asl new file mode 100644 index 0000000..e534e8b --- /dev/null +++ b/src/soc/intel/common/block/acpi/acpi/pmc.asl @@ -0,0 +1,21 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2020 Intel Corp. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +Device (PEPD) +{ + Name (_HID, "INT33A1" /* Intel Power Engine */) + Name (_CID, EisaId ("PNP0D80") /* System Power Management Controller */) + Name (_UID, One) +}