Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44359 )
Change subject: mainboard/google/volteer: Enable long cr50 ready pulses
......................................................................
Patch Set 4:
Putting some code in soc/intel/tigerlake guarded by TPM_CR50 will nicely separate category 1 from the other two. However, we need some mainboard declarations in order to distinguish between categories 2 and 3.
Okay, fair enough, that's a reasonable argument. I'll let the x86 guys chime in on where they think this should be. Either option sounds reasonable to me.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44359
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idef1fffd410a345678da4b3c8aea46ac74a01470
Gerrit-Change-Number: 44359
Gerrit-PatchSet: 4
Gerrit-Owner: Jes Klinke
jbk@chromium.org
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jes Klinke
jbk@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 13 Aug 2020 01:15:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment