Attention is currently required from: Jason Glenesk, Raul Rangel, Jason Nien, Matt DeVillier, Martin Roth, Fred Reitberger, Felix Held.
Hello Jason Glenesk, Raul Rangel, Jason Nien, Matt DeVillier, Martin Roth, Fred Reitberger, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/69852
to look at the new patch set (#4).
Change subject: util/amdfwtool: Deal with psp position in flash offset directly ......................................................................
util/amdfwtool: Deal with psp position in flash offset directly
Using a memory mapped offset is simply wrong to specify the PSP base as it depends on the flash size. Setting the flash offset directly in Kconfig allows to remove a lot of unnecessary aritmetics in both amdfwtool and Makefile. It also gets rid of the weird index semantics.
This does not result in identical files as amdfwutil images differ depending on stack usage.
TESTED: google/vilboz still boots.
Change-Id: I89c9e73e7db748379c97e3c0ad69af3faedc8d66 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/mainboard/amd/birman/Kconfig M src/mainboard/amd/chausie/Kconfig M src/mainboard/amd/majolica/Kconfig M src/mainboard/amd/mandolin/Kconfig M src/mainboard/google/guybrush/Kconfig M src/mainboard/google/kahlee/Kconfig M src/mainboard/google/skyrim/Kconfig M src/mainboard/google/zork/Kconfig M src/soc/amd/cezanne/Kconfig M src/soc/amd/cezanne/Makefile.inc M src/soc/amd/common/Makefile.inc M src/soc/amd/common/block/include/amdblocks/psp_efs.h M src/soc/amd/common/block/psp/Kconfig M src/soc/amd/glinda/Kconfig M src/soc/amd/glinda/Makefile.inc M src/soc/amd/mendocino/Kconfig M src/soc/amd/mendocino/Makefile.inc M src/soc/amd/morgana/Kconfig M src/soc/amd/morgana/Makefile.inc M src/soc/amd/picasso/Kconfig M src/soc/amd/picasso/Makefile.inc M src/soc/amd/stoneyridge/Kconfig M src/soc/amd/stoneyridge/Makefile.inc M src/soc/amd/stoneyridge/fch.c M util/amdfwtool/amdfwtool.c 25 files changed, 109 insertions(+), 324 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/69852/4