Attention is currently required from: Angel Pons.
Felix Held has posted comments on this change by Angel Pons. ( https://review.coreboot.org/c/coreboot/+/74121?usp=email )
Change subject: drivers/option: Add forms in cbtables ......................................................................
Patch Set 30:
(6 comments)
Patchset:
PS30: only read the first document so far and it looks reasonable to me. found a few things; would be good if those will get addressed in follow-up patches
File Documentation/drivers/cfr.md:
https://review.coreboot.org/c/coreboot/+/74121/comment/b98d6cfb_fcf8de1f?usp... : PS30, Line 1: form representation hmm, didn't we agree in a meeting that we wanted to get rid of this uefi terminology here which is also not that descriptive of what this is?
https://review.coreboot.org/c/coreboot/+/74121/comment/bf58a844_36ac0e2c?usp... : PS30, Line 29: ore or
https://review.coreboot.org/c/coreboot/+/74121/comment/6cb64e93_bc9e9d19?usp... : PS30, Line 58: jumping `size` bytes forward. i like this design
https://review.coreboot.org/c/coreboot/+/74121/comment/edb149b2_34617326?usp... : PS30, Line 69: immideatly immediately
https://review.coreboot.org/c/coreboot/+/74121/comment/99334641_55fd887e?usp... : PS30, Line 72: the doc would be slightly easier to read if all tags were first defined and then used. right now some tags are referenced before they are introduces and at least for me it makes this slightly more difficult to read and understand