22 Apr
2020
22 Apr
'20
4:12 p.m.
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31371 )
Change subject: mb/kontron/mAL10: Add new mainboard ......................................................................
Patch Set 6:
(1 comment)
We should split the patch up into soc vs mainboard patches.
https://review.coreboot.org/c/coreboot/+/31371/6/src/lib/bootblock.c File src/lib/bootblock.c:
https://review.coreboot.org/c/coreboot/+/31371/6/src/lib/bootblock.c@11 PS6, Line 11: #include <reset.h> Why is this in here?
--
To view, visit https://review.coreboot.org/c/coreboot/+/31371
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib3d09e4eb23655825b7603f49f0bad31116ac6e1
Gerrit-Change-Number: 31371
Gerrit-PatchSet: 6
Gerrit-Owner: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Andrey Petrov andrey.petrov@gmail.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Ravishankar Sarawadi ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 22 Apr 2020 14:12:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment